db-snapshot: propagate any node snapshot error through RPC callhandle_snapshot_errors

In particular, it means that "garage meta snapshot --all" will get an exit
code of 1 if any node fails to snapshot.

This makes sure that any external tool trying to snapshot nodes (e.g. from
cron) will be aware of the failure.

Fix #920

1 files changed, 5 insertions, 1 deletions

diff --git a/src/garage/admin/mod.rs b/src/garage/admin/mod.rs
index 176911fb..1a4ff853 100644
--- a/src/garage/admin/mod.rs
+++ b/src/garage/admin/mod.rs
@@ -497,7 +497,11 @@ impl AdminRpcHandler {
 					ret.push(format!("{:?}\t{}", to, res_str));
 				}
 
-				Ok(AdminRpc::Ok(format_table_to_string(ret)))
+				if resps.iter().any(Result::is_err) {
+					Err(GarageError::Message(format_table_to_string(ret)).into())
+				} else {
+					Ok(AdminRpc::Ok(format_table_to_string(ret)))
+				}
 			}
 			MetaOperation::Snapshot { all: false } => {
 				garage_model::snapshot::async_snapshot_metadata(&self.garage).await?;