diff options
| author | Alex Auvolat <lx@deuxfleurs.fr> | 2025-02-18 12:56:09 +0100 |
|---|---|---|
| committer | Alex Auvolat <lx@deuxfleurs.fr> | 2025-02-18 15:33:42 +0100 |
| commit | 45e10e55f9761d79aa8d5b7dbaeb56d4d535629e (patch) | |
| tree | 3d70ad5e1c94f30635c0e71fa0beb5b27f7fc497 /src/api/s3/get.rs | |
| parent | 730bfee753c4f22cd0595d9195222de334ec36f9 (diff) | |
| download | garage-45e10e55f9761d79aa8d5b7dbaeb56d4d535629e.tar.gz garage-45e10e55f9761d79aa8d5b7dbaeb56d4d535629e.zip | |
update aws-sdk-s3 in tests and fix wrong checksumming behavior in GetObject
Diffstat (limited to 'src/api/s3/get.rs')
| -rw-r--r-- | src/api/s3/get.rs | 14 |
1 files changed, 12 insertions, 2 deletions
diff --git a/src/api/s3/get.rs b/src/api/s3/get.rs index 15929cd1..bcb72cc3 100644 --- a/src/api/s3/get.rs +++ b/src/api/s3/get.rs @@ -340,7 +340,12 @@ pub async fn handle_get_without_ctx( enc, &headers, pn, - checksum_mode, + ChecksumMode { + // TODO: for multipart uploads, checksums of each part should be stored + // so that we can return the corresponding checksum here + // https://docs.aws.amazon.com/AmazonS3/latest/userguide/checking-object-integrity.html + enabled: false, + }, ) .await } @@ -354,7 +359,12 @@ pub async fn handle_get_without_ctx( &headers, range.start, range.start + range.length, - checksum_mode, + ChecksumMode { + // TODO: for range queries that align with part boundaries, + // we should return the saved checksum of the part + // https://docs.aws.amazon.com/AmazonS3/latest/userguide/checking-object-integrity.html + enabled: false, + }, ) .await } |