diff options
| author | Maximilien R <maximilien@deuxfleurs.fr> | 2022-12-12 00:53:57 +0100 |
|---|---|---|
| committer | Maximilien R <maximilien@deuxfleurs.fr> | 2022-12-12 00:53:57 +0100 |
| commit | 980572a8872c56ea9572ff03579ebb9a65013775 (patch) | |
| tree | 946776bf1ab7818ac94a253d263b13607c82d8b3 /script/helm/garage/values.yaml | |
| parent | defd7d9e6353e10b0b9d58b66aad4f04e7d50c41 (diff) | |
| parent | 7a0014b6f71f9d4a445b378deb215b088e02e036 (diff) | |
| download | garage-980572a8872c56ea9572ff03579ebb9a65013775.tar.gz garage-980572a8872c56ea9572ff03579ebb9a65013775.zip | |
Merge pull request 'helm: ingress improvements' (#422) from patrickjahns:helm-refactor-ingress into main
As discussed in the chat yesterday, I want to propose to disable the ingress per default.
The motivation behind this change is, that per default the ingress is "misconfigured"
meaning it can not work with the default values and requires a user of the chart to
add additional configuration. When installing the chart per default, I would not
expect to already expose garage publicly without my explicit configuration to do so
Commenting the ingressClass resource also allows for relying only on
annotations - otherwise the ingressClass would be always set to nginx
or require a user to override it with ingressClass: null
A small change on top, I've added the ability to specify user defined labels per ingress
Diffstat (limited to 'script/helm/garage/values.yaml')
| -rw-r--r-- | script/helm/garage/values.yaml | 15 |
1 files changed, 10 insertions, 5 deletions
diff --git a/script/helm/garage/values.yaml b/script/helm/garage/values.yaml index 08d0c09b..608ee53c 100644 --- a/script/helm/garage/values.yaml +++ b/script/helm/garage/values.yaml @@ -85,14 +85,15 @@ service: ingress: s3: api: - enabled: true + enabled: false # Rely either on the className or the annotation below but not both # replace "nginx" by an Ingress controller # you can find examples here https://kubernetes.io/docs/concepts/services-networking/ingress-controllers - className: "nginx" - annotations: + # className: "nginx" + annotations: {} # kubernetes.io/ingress.class: "nginx" # kubernetes.io/tls-acme: "true" + labels: {} hosts: - host: "s3.garage.tld" # garage S3 API endpoint paths: @@ -107,11 +108,15 @@ ingress: # hosts: # - kubernetes.docker.internal web: - enabled: true - className: "nginx" + enabled: false + # Rely either on the className or the annotation below but not both + # replace "nginx" by an Ingress controller + # you can find examples here https://kubernetes.io/docs/concepts/services-networking/ingress-controllers + # className: "nginx" annotations: {} # kubernetes.io/ingress.class: nginx # kubernetes.io/tls-acme: "true" + labels: {} hosts: - host: "*.web.garage.tld" # wildcard website access with bucket name prefix paths: |