From f58a813a36de7b356d72ba1e6f2f991da5491285 Mon Sep 17 00:00:00 2001 From: Patrick Jahns Date: Wed, 16 Nov 2022 12:18:11 +0100 Subject: refactor(helm): disable the ingress per default The default values forces people to create an ingress resources, where per default an ingress is not necessary to start garage. If someone wants to utilize an ingress, he would need to define the values for the ingress either way, so enabling the ingress explicitly makes more sense, then requiring it to be disabled per default --- script/helm/garage/values.yaml | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) (limited to 'script/helm/garage/values.yaml') diff --git a/script/helm/garage/values.yaml b/script/helm/garage/values.yaml index 08d0c09b..9c1c54c0 100644 --- a/script/helm/garage/values.yaml +++ b/script/helm/garage/values.yaml @@ -85,12 +85,12 @@ service: ingress: s3: api: - enabled: true + enabled: false # Rely either on the className or the annotation below but not both # replace "nginx" by an Ingress controller # you can find examples here https://kubernetes.io/docs/concepts/services-networking/ingress-controllers - className: "nginx" - annotations: + # className: "nginx" + annotations: {} # kubernetes.io/ingress.class: "nginx" # kubernetes.io/tls-acme: "true" hosts: @@ -107,8 +107,11 @@ ingress: # hosts: # - kubernetes.docker.internal web: - enabled: true - className: "nginx" + enabled: false + # Rely either on the className or the annotation below but not both + # replace "nginx" by an Ingress controller + # you can find examples here https://kubernetes.io/docs/concepts/services-networking/ingress-controllers + # className: "nginx" annotations: {} # kubernetes.io/ingress.class: nginx # kubernetes.io/tls-acme: "true" -- cgit v1.2.3 From edb0b9c1ee30a595833fd0bf46b42b3bb165b299 Mon Sep 17 00:00:00 2001 From: Patrick Jahns Date: Wed, 16 Nov 2022 12:21:18 +0100 Subject: feat(helm): allow to add custom labels to created ingress resources --- script/helm/garage/values.yaml | 2 ++ 1 file changed, 2 insertions(+) (limited to 'script/helm/garage/values.yaml') diff --git a/script/helm/garage/values.yaml b/script/helm/garage/values.yaml index 9c1c54c0..608ee53c 100644 --- a/script/helm/garage/values.yaml +++ b/script/helm/garage/values.yaml @@ -93,6 +93,7 @@ ingress: annotations: {} # kubernetes.io/ingress.class: "nginx" # kubernetes.io/tls-acme: "true" + labels: {} hosts: - host: "s3.garage.tld" # garage S3 API endpoint paths: @@ -115,6 +116,7 @@ ingress: annotations: {} # kubernetes.io/ingress.class: nginx # kubernetes.io/tls-acme: "true" + labels: {} hosts: - host: "*.web.garage.tld" # wildcard website access with bucket name prefix paths: -- cgit v1.2.3