diff options
| author | Alex Auvolat <alex@adnab.me> | 2024-03-01 13:11:41 +0100 |
|---|---|---|
| committer | Alex Auvolat <alex@adnab.me> | 2024-03-01 13:12:18 +0100 |
| commit | a36248a1695de02cc19b25ba127810bd32b6d350 (patch) | |
| tree | 60e55896f3225ce5dc26bfc3d370daf7fd382338 /nix/compile.nix | |
| parent | b8c7a560ef339142607106649f8cef88def82fb8 (diff) | |
| download | garage-a36248a1695de02cc19b25ba127810bd32b6d350.tar.gz garage-a36248a1695de02cc19b25ba127810bd32b6d350.zip | |
[fix-signed-headers] aws signatures v4: don't actually check Content-Type is signed
This page of the AWS docs indicate that Content-Type should be part of
the CanonicalHeaders (and therefore SignedHeaders) strings in signature
calculation:
https://docs.aws.amazon.com/AmazonS3/latest/API/sig-v4-header-based-auth.html
However, testing with Minio Client revealed that it did not sign the
Content-Type header, and therefore we broke CI by expecting it to be
signed. With this commit, we don't mandate Content-Type to be signed
anymore, for better compatibility with the ecosystem. Testing against
the official behavior of S3 on AWS has not been done.
Diffstat (limited to 'nix/compile.nix')
0 files changed, 0 insertions, 0 deletions