aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlex Auvolat <alex@adnab.me>2022-04-07 10:24:20 +0200
committerAlex Auvolat <alex@adnab.me>2022-04-07 10:24:20 +0200
commit8ba6707a9b7f30e304b590c643d72216fa574e26 (patch)
tree4c2b55d5e3dc2024ac1b34a0640538d8d86bd6c3
parent9fd8ec1dee367c773d51cdc035879ea43abb1cbf (diff)
downloadgarage-reduce-maximum-backoff.tar.gz
garage-reduce-maximum-backoff.zip
Bring maximum exponential backoff time down from 16h to 1hreduce-maximum-backoff
-rw-r--r--src/block/manager.rs6
1 files changed, 5 insertions, 1 deletions
diff --git a/src/block/manager.rs b/src/block/manager.rs
index a3c4ec0d..1c04a335 100644
--- a/src/block/manager.rs
+++ b/src/block/manager.rs
@@ -46,6 +46,9 @@ const NEED_BLOCK_QUERY_TIMEOUT: Duration = Duration::from_secs(5);
// and the time when it is retried, with exponential backoff
// (multiplied by 2, 4, 8, 16, etc. for every consecutive failure).
const RESYNC_RETRY_DELAY: Duration = Duration::from_secs(60);
+// The minimum retry delay is 60 seconds = 1 minute
+// The maximum retry delay is 60 seconds * 2^6 = 60 seconds << 6 = 64 minutes (~1 hour)
+const RESYNC_RETRY_DELAY_MAX_BACKOFF_POWER: u64 = 6;
// The delay between the moment when the reference counter
// drops to zero, and the moment where we allow ourselves
@@ -985,7 +988,8 @@ impl ErrorCounter {
}
fn delay_msec(&self) -> u64 {
- (RESYNC_RETRY_DELAY.as_millis() as u64) << std::cmp::min(self.errors - 1, 10)
+ (RESYNC_RETRY_DELAY.as_millis() as u64)
+ << std::cmp::min(self.errors - 1, RESYNC_RETRY_DELAY_MAX_BACKOFF_POWER)
}
fn next_try(&self) -> u64 {
self.last_try + self.delay_msec()