diff options
| author | Alex Auvolat <alex@adnab.me> | 2023-10-20 10:29:03 +0200 |
|---|---|---|
| committer | Alex Auvolat <alex@adnab.me> | 2023-10-20 10:37:48 +0200 |
| commit | ac04934daefe48ac4f41d22b9129d1fe2ce44833 (patch) | |
| tree | 9a6d7cba43c1f58b6ad9006b8af5007e5645733b | |
| parent | 0215b114028c9a9987c1581e50820a42e069ffe5 (diff) | |
| download | garage-fix-cors-post-object.tar.gz garage-fix-cors-post-object.zip | |
s3 api: add missing CORS headers to PostObject responses (fix #609)fix-cors-post-object
| -rw-r--r-- | src/api/s3/post_object.rs | 13 |
1 files changed, 10 insertions, 3 deletions
diff --git a/src/api/s3/post_object.rs b/src/api/s3/post_object.rs index 542b7a81..f9eccb7f 100644 --- a/src/api/s3/post_object.rs +++ b/src/api/s3/post_object.rs @@ -15,6 +15,7 @@ use serde::Deserialize; use garage_model::garage::Garage; +use crate::s3::cors::*; use crate::s3::error::*; use crate::s3::put::{get_headers, save_stream}; use crate::s3::xml as s3_xml; @@ -242,7 +243,7 @@ pub async fn handle_post_object( let etag = format!("\"{}\"", md5); - let resp = if let Some(mut target) = params + let mut resp = if let Some(mut target) = params .get("success_action_redirect") .and_then(|h| h.to_str().ok()) .and_then(|u| url::Url::parse(u).ok()) @@ -262,8 +263,7 @@ pub async fn handle_post_object( } else { let path = head .uri - .into_parts() - .path_and_query + .path_and_query() .map(|paq| paq.path().to_string()) .unwrap_or_else(|| "/".to_string()); let authority = head @@ -308,6 +308,13 @@ pub async fn handle_post_object( } }; + let matching_cors_rule = + find_matching_cors_rule(&bucket, &Request::from_parts(head, Body::empty()))?; + if let Some(rule) = matching_cors_rule { + add_cors_headers(&mut resp, rule) + .ok_or_internal_error("Invalid bucket CORS configuration")?; + } + Ok(resp) } |