From 395f942fc745f5947005cad3a0e2ac15403fdbc9 Mon Sep 17 00:00:00 2001
From: Alex Auvolat <alex@adnab.me>
Date: Tue, 13 Sep 2022 12:34:03 +0200
Subject: Fix potential memory leak

---
 src/send.rs | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

(limited to 'src')

diff --git a/src/send.rs b/src/send.rs
index 4e16179..0db0ba7 100644
--- a/src/send.rs
+++ b/src/send.rs
@@ -118,6 +118,9 @@ impl SendQueuePriority {
 				let order_vec = self.order.get_mut(&stream).unwrap();
 				let j = order_vec.iter().position(|x| *x == order).unwrap();
 				order_vec.remove(j).unwrap();
+				if order_vec.is_empty() {
+					self.order.remove(&stream);
+				}
 			}
 		}
 	}
@@ -147,14 +150,19 @@ impl SendQueuePriority {
 				item.sent += data_frame.data().len();
 
 				if eos || is_err {
+					// If item had an order tag, remove it from the corresponding ordering list
 					if let Some(OrderTag(stream, order)) = item.order_tag {
-						assert_eq!(
-							self.order.get_mut(&stream).unwrap().pop_front(),
-							Some(order)
-						)
+						let order_stream = self.order.get_mut(&stream).unwrap();
+						assert_eq!(order_stream.pop_front(), Some(order));
+						if order_stream.is_empty() {
+							self.order.remove(&stream);
+						}
 					}
+					// Remove item from sending queue
 					self.items.remove(j);
 				} else {
+					// Move item later in send queue to implement LAS scheduling
+					// (LAS = Least Attained Service)
 					for k in j..self.items.len() - 1 {
 						if self.items[k].sent >= self.items[k + 1].sent {
 							self.items.swap(k, k + 1);
-- 
cgit v1.2.3