From a36248a1695de02cc19b25ba127810bd32b6d350 Mon Sep 17 00:00:00 2001 From: Alex Auvolat Date: Fri, 1 Mar 2024 13:11:41 +0100 Subject: [fix-signed-headers] aws signatures v4: don't actually check Content-Type is signed This page of the AWS docs indicate that Content-Type should be part of the CanonicalHeaders (and therefore SignedHeaders) strings in signature calculation: https://docs.aws.amazon.com/AmazonS3/latest/API/sig-v4-header-based-auth.html However, testing with Minio Client revealed that it did not sign the Content-Type header, and therefore we broke CI by expecting it to be signed. With this commit, we don't mandate Content-Type to be signed anymore, for better compatibility with the ecosystem. Testing against the official behavior of S3 on AWS has not been done. --- script/test-smoke.sh | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'script') diff --git a/script/test-smoke.sh b/script/test-smoke.sh index 6965c0f3..9f9ea50c 100755 --- a/script/test-smoke.sh +++ b/script/test-smoke.sh @@ -81,11 +81,9 @@ if [ -z "$SKIP_AWS" ]; then echo "Invalid multipart upload" exit 1 fi + aws s3api delete-object --bucket eprouvette --key upload fi -echo "OK!!" -exit 0 - # S3CMD if [ -z "$SKIP_S3CMD" ]; then echo "🛠️ Testing with s3cmd" -- cgit v1.2.3 From 6a7623e90d19c670b4fbb3ae6bc51c4c291765f3 Mon Sep 17 00:00:00 2001 From: Alex Auvolat Date: Fri, 1 Mar 2024 15:14:06 +0100 Subject: [rel-0.9.2] Bump version to v0.9.2 --- script/helm/garage/Chart.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'script') diff --git a/script/helm/garage/Chart.yaml b/script/helm/garage/Chart.yaml index 31b75c1f..9a21aa8e 100644 --- a/script/helm/garage/Chart.yaml +++ b/script/helm/garage/Chart.yaml @@ -21,4 +21,4 @@ version: 0.4.1 # incremented each time you make changes to the application. Versions are not expected to # follow Semantic Versioning. They should reflect the version the application is using. # It is recommended to use it with quotes. -appVersion: "v0.9.1" +appVersion: "v0.9.2" -- cgit v1.2.3 From 8670140358353542b0c92b7b72a1d223ea2fe068 Mon Sep 17 00:00:00 2001 From: Alex Auvolat Date: Mon, 4 Mar 2024 14:00:55 +0100 Subject: [rel-0.9.3] Bump version to 0.9.3 --- script/helm/garage/Chart.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'script') diff --git a/script/helm/garage/Chart.yaml b/script/helm/garage/Chart.yaml index 9a21aa8e..71906cfb 100644 --- a/script/helm/garage/Chart.yaml +++ b/script/helm/garage/Chart.yaml @@ -21,4 +21,4 @@ version: 0.4.1 # incremented each time you make changes to the application. Versions are not expected to # follow Semantic Versioning. They should reflect the version the application is using. # It is recommended to use it with quotes. -appVersion: "v0.9.2" +appVersion: "v0.9.3" -- cgit v1.2.3