aboutsummaryrefslogtreecommitdiff
path: root/src/model/object_table.rs
Commit message (Collapse)AuthorAgeFilesLines
* Implement ListMultipartUploads (#171)Quentin2022-01-121-3/+11
| | | | | | | | | | | | | | | | | | | | | | | Implement ListMultipartUploads, also refactor ListObjects and ListObjectsV2. It took me some times as I wanted to propose the following things: - Using an iterator instead of the loop+goto pattern. I find it easier to read and it should enable some optimizations. For example, when consuming keys of a common prefix, we do many [redundant checks](https://git.deuxfleurs.fr/Deuxfleurs/garage/src/branch/main/src/api/s3_list.rs#L125-L156) while the only thing to do is to [check if the following key is still part of the common prefix](https://git.deuxfleurs.fr/Deuxfleurs/garage/src/branch/feature/s3-multipart-compat/src/api/s3_list.rs#L476). - Try to name things (see ExtractionResult and RangeBegin enums) and to separate concerns (see ListQuery and Accumulator) - An IO closure to make unit tests possibles. - Unit tests, to track regressions and document how to interact with the code - Integration tests with `s3api`. In the future, I would like to move them in Rust with the aws rust SDK. Merging of the logic of ListMultipartUploads and ListObjects was not a goal but a consequence of the previous modifications. Some points that we might want to discuss: - ListObjectsV1, when using pagination and delimiters, has a weird behavior (it lists multiple times the same prefix) with `aws s3api` due to the fact that it can not use our optimization to skip the whole prefix. It is independant from my refactor and can be tested with the commented `s3api` tests in `test-smoke.sh`. It probably has the same weird behavior on the official AWS S3 implementation. - Considering ListMultipartUploads, I had to "abuse" upload id marker to support prefix skipping. I send an `upload-id-marker` with the hardcoded value `include` to emulate your "including" token. - Some ways to test ListMultipartUploads with existing software (my tests are limited to s3api for now). Co-authored-by: Quentin Dufour <quentin@deuxfleurs.fr> Reviewed-on: https://git.deuxfleurs.fr/Deuxfleurs/garage/pulls/171 Co-authored-by: Quentin <quentin@dufour.io> Co-committed-by: Quentin <quentin@dufour.io>
* New buckets for 0.6.0: fix model and migrationAlex Auvolat2022-01-041-5/+2
|
* New buckets for 0.6.0: migration code and build filesAlex Auvolat2022-01-041-0/+71
|
* New model for bucketsAlex Auvolat2022-01-041-8/+8
|
* Make table name a const in traitAlex Auvolat2021-12-151-0/+2
|
* rename types to CamelCaseTrinity Pointard2021-05-031-5/+5
|
* fix clippy warnings on modelTrinity Pointard2021-05-031-10/+4
|
* change a few commentsAlex Auvolat2021-04-271-2/+2
|
* make most requested changesTrinity Pointard2021-04-271-7/+7
|
* attempt at documenting model crateTrinity Pointard2021-04-271-4/+34
|
* attempt at documenting table crateTrinity Pointard2021-04-271-1/+1
|
* Improve bootstraping: do it regularly; persist peer listAlex Auvolat2021-04-271-1/+3
|
* GC object table in a specific caseAlex Auvolat2021-03-161-0/+3
|
* Some improvements in background worker but we terminate lateAlex Auvolat2021-03-151-2/+1
|
* WIP migrate to tokio 1Alex Auvolat2021-03-151-1/+2
|
* WIP big refactoringAlex Auvolat2021-03-111-1/+1
|
* Very minor changesAlex Auvolat2021-03-101-1/+0
|
* Remove migration paths from 0.1 branchAlex Auvolat2021-03-101-52/+0
|
* Refactor model stuff, including cleaner CRDTsAlex Auvolat2021-03-101-22/+17
|
* Make updated() be a sync function that doesn't failAlex Auvolat2021-02-231-27/+26
|
* Slight refactoring to make things clearer with DeletedFilterAlex Auvolat2020-11-201-3/+4
|
* cargo fmtAlex Auvolat2020-07-081-86/+91
|
* Add multiple headers to object modelAlex Auvolat2020-07-081-7/+24
|
* (WIP) New object table model, TODO: update API calls to use itAlex Auvolat2020-07-081-27/+92
|
* Rename garage_core to garage_modelAlex Auvolat2020-07-071-0/+198
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-01 23:35:23 +0000