aboutsummaryrefslogtreecommitdiff
path: root/src/api
Commit message (Collapse)AuthorAgeFilesLines
* Implement ListMultipartUploads (#171)Quentin2022-01-126-253/+1087
| | | | | | | | | | | | | | | | | | | | | | | Implement ListMultipartUploads, also refactor ListObjects and ListObjectsV2. It took me some times as I wanted to propose the following things: - Using an iterator instead of the loop+goto pattern. I find it easier to read and it should enable some optimizations. For example, when consuming keys of a common prefix, we do many [redundant checks](https://git.deuxfleurs.fr/Deuxfleurs/garage/src/branch/main/src/api/s3_list.rs#L125-L156) while the only thing to do is to [check if the following key is still part of the common prefix](https://git.deuxfleurs.fr/Deuxfleurs/garage/src/branch/feature/s3-multipart-compat/src/api/s3_list.rs#L476). - Try to name things (see ExtractionResult and RangeBegin enums) and to separate concerns (see ListQuery and Accumulator) - An IO closure to make unit tests possibles. - Unit tests, to track regressions and document how to interact with the code - Integration tests with `s3api`. In the future, I would like to move them in Rust with the aws rust SDK. Merging of the logic of ListMultipartUploads and ListObjects was not a goal but a consequence of the previous modifications. Some points that we might want to discuss: - ListObjectsV1, when using pagination and delimiters, has a weird behavior (it lists multiple times the same prefix) with `aws s3api` due to the fact that it can not use our optimization to skip the whole prefix. It is independant from my refactor and can be tested with the commented `s3api` tests in `test-smoke.sh`. It probably has the same weird behavior on the official AWS S3 implementation. - Considering ListMultipartUploads, I had to "abuse" upload id marker to support prefix skipping. I send an `upload-id-marker` with the hardcoded value `include` to emulate your "including" token. - Some ways to test ListMultipartUploads with existing software (my tests are limited to s3api for now). Co-authored-by: Quentin Dufour <quentin@deuxfleurs.fr> Reviewed-on: https://git.deuxfleurs.fr/Deuxfleurs/garage/pulls/171 Co-authored-by: Quentin <quentin@dufour.io> Co-committed-by: Quentin <quentin@dufour.io>
* Clarify error messageAlex Auvolat2022-01-102-9/+10
|
* Fix unit testsAlex Auvolat2022-01-052-12/+44
|
* Fix some error codesAlex Auvolat2022-01-058-36/+53
|
* Implement DeleteBucketAlex Auvolat2022-01-053-6/+116
|
* Implement CreateBucketAlex Auvolat2022-01-052-16/+151
|
* Small changes in key model and refactoringnew-bucketsAlex Auvolat2022-01-042-5/+6
|
* New buckets for 0.6.0: make bucket id a SK and not a HK, CLI updatesAlex Auvolat2022-01-042-14/+10
|
* New buckets for 0.6.0: small changesAlex Auvolat2022-01-042-7/+5
| | | | | | | | | | | | - Fix bucket delete - fix merge of bucket creation date - Replace deletable with option in aliases Rationale: if two aliases point to conflicting bucket, resolving by making an arbitrary choice risks making data accessible when it shouldn't be. We'd rather resolve to deleting the alias until someone puts it back.
* Remove website redirectsAlex Auvolat2022-01-041-9/+9
|
* Some movement of helper code and refactoring of error handlingAlex Auvolat2022-01-041-0/+10
|
* New buckets for 0.6.0: fix model and migrationAlex Auvolat2022-01-042-18/+43
|
* Fix forgotten flagAlex Auvolat2022-01-041-1/+1
|
* New buckets for 0.6.0: small fixes, including:Alex Auvolat2022-01-043-8/+4
| | | | | | | | - ensure bucket names are correct aws s3 names - when making aliases, ensure timestamps of links in both ways are the same - fix small remarks by trinity - don't have a separate website_access field
* Model changesAlex Auvolat2022-01-043-20/+22
|
* New model for bucketsAlex Auvolat2022-01-0410-95/+208
|
* less strict ListBuckets (#178)trinity-1686a2021-12-151-5/+1
| | | | | | | | | fix #175 Co-authored-by: Trinity Pointard <trinity.pointard@gmail.com> Reviewed-on: https://git.deuxfleurs.fr/Deuxfleurs/garage/pulls/178 Co-authored-by: trinity-1686a <trinity.pointard@gmail.com> Co-committed-by: trinity-1686a <trinity.pointard@gmail.com>
* BucketWebsite (#174)trinity-1686a2021-12-154-4/+318
| | | | | | | | | | | fix #77 this does not store anything but a on/off switch for website, and does not implement GetBucketWebsite as it would require storing more. GetBucketWebsite should be pretty easy to implement once data is stored though. Co-authored-by: Trinity Pointard <trinity.pointard@gmail.com> Reviewed-on: https://git.deuxfleurs.fr/Deuxfleurs/garage/pulls/174 Co-authored-by: trinity-1686a <trinity.pointard@gmail.com> Co-committed-by: trinity-1686a <trinity.pointard@gmail.com>
* add proper request router for s3 api (#163)trinity-1686a2021-12-067-185/+1476
| | | | | | | | | | | | | fix #161 Current request router was organically grown, and is getting messier and messier with each addition. This router cover exaustively existing API endpoints (with exceptions listed in [#161(comment)](https://git.deuxfleurs.fr/Deuxfleurs/garage/issues/161#issuecomment-1773) either because new and old api endpoint can't feasabily be differentied, or it's more lambda than s3). Co-authored-by: Trinity Pointard <trinity.pointard@gmail.com> Reviewed-on: https://git.deuxfleurs.fr/Deuxfleurs/garage/pulls/163 Reviewed-by: Alex <alex@adnab.me> Co-authored-by: trinity-1686a <trinity.pointard@gmail.com> Co-committed-by: trinity-1686a <trinity.pointard@gmail.com>
* Improved handling of HTTP rangestrinity-1686a2021-11-293-13/+35
| | | | | | | | | | | - correct HTTP code when range syntax is invalid (fix #140) - when multiple ranges are given, simply ignore and send whole file Co-authored-by: Trinity Pointard <trinity.pointard@gmail.com> Reviewed-on: https://git.deuxfleurs.fr/Deuxfleurs/garage/pulls/157 Reviewed-by: Alex <alex@adnab.me> Co-authored-by: trinity-1686a <trinity.pointard@gmail.com> Co-committed-by: trinity-1686a <trinity.pointard@gmail.com>
* In ListBuckets, hide entry if no permsfeature/hide-buckets-without-permQuentin Dufour2021-11-221-0/+1
|
* Improve how node roles are assigned in Garagev0.5-beta1Alex Auvolat2021-11-161-4/+5
| | | | | | | | | | | | | | | | | - change the terminology: the network configuration becomes the role table, the configuration of a nodes becomes a node's role - the modification of the role table takes place in two steps: first, changes are staged in a CRDT data structure. Then, once the user is happy with the changes, they can commit them all at once (or revert them). - update documentation - fix tests - implement smarter partition assignation algorithm This patch breaks the format of the network configuration: when migrating, the cluster will be in a state where no roles are assigned. All roles must be re-assigned and commited at once. This migration should not pose an issue.
* update doc and commentsTrinity Pointard2021-11-162-4/+5
|
* clippyTrinity Pointard2021-11-161-1/+1
|
* fix issue where list on vhost-bucket would list bucket instead of bucket contentTrinity Pointard2021-11-161-73/+29
|
* add support for vhost-style s3 bucketTrinity Pointard2021-11-164-9/+217
|
* Fix clippy lints (fix #121)Alex Auvolat2021-10-265-33/+31
|
* Improve CLI, adapt tests, update documentationAlex Auvolat2021-10-251-2/+6
|
* Improvements to CLI and various fixes for netapp versionAlex Auvolat2021-10-222-3/+7
| | | | Discovery via consul, persist peer list to file
* First port of Garage to NetappAlex Auvolat2021-10-221-4/+4
|
* Fix HTTP return code for DeleteObject (fix #98)Alex Auvolat2021-10-111-1/+2
|
* WIP: try to fix #93, and improve S3 ListObjects (v1 and v2) API callsAlex Auvolat2021-10-111-58/+160
|
* Prepare for v0.3.0 and add migration path from v0.2.1.xv0.3.0Alex Auvolat2021-05-281-4/+4
|
* Add basic support for the "Versioning" commandQuentin Dufour2021-05-143-0/+48
|
* Improved XML serializationbetter_xmlAlex Auvolat2021-05-069-280/+727
| | | | | | - Use quick_xml and serde for all XML response returned by the S3 API. - Include tests for all structs used to generate XML - Remove old manual XML escaping function which was unsafe
* rename types to CamelCaseTrinity Pointard2021-05-034-18/+17
|
* fix clippy warnings on apiTrinity Pointard2021-05-038-81/+85
|
* S3 API: support ListBucketsQuentin Dufour2021-05-034-2/+99
|
* Remove STREAMING-AWS4-HMAC-SHA256-PAYLOAD (see #64)Alex Auvolat2021-05-031-3/+1
|
* Many S3 compatibility improvements:v0.2.1.5Alex Auvolat2021-04-286-16/+98
| | | | | | | | - return XML errors - implement AuthorizationHeaderMalformed error to redirect clients to correct location (used by minio client) - implement GetBucketLocation - fix DeleteObjects XML parsing and response
* Fix #59 (& issue)Alex Auvolat2021-04-271-1/+2
|
* make most requested changesTrinity Pointard2021-04-272-3/+2
|
* document api crateTrinity Pointard2021-04-275-9/+39
|
* update to v0.2.1v0.2.1release-v0.2.1Alex Auvolat2021-03-191-4/+4
|
* Update Cargo.toml files with AGPL license infov0.2.0Alex Auvolat2021-03-181-11/+11
|
* Add trinity's comment in the codeAlex Auvolat2021-03-181-0/+5
|
* Merge pull request 'add support for caching headers' (#49) from ↵Alex2021-03-182-2/+45
|\ | | | | | | | | | | trinity-1686a/garage:cache-headers into master Reviewed-on: https://git.deuxfleurs.fr/Deuxfleurs/garage/pulls/49
| * add support for caching headersTrinity Pointard2021-03-182-2/+45
| |
* | Prepare for release 0.2Alex Auvolat2021-03-181-4/+4
|/
* Update dependenciesAlex Auvolat2021-03-164-27/+32
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-10 16:07:55 +0000