aboutsummaryrefslogtreecommitdiff
path: root/src/table/merkle.rs
diff options
context:
space:
mode:
authorTrinity Pointard <trinity.pointard@gmail.com>2021-04-23 21:42:52 +0200
committerAlex Auvolat <alex@adnab.me>2021-05-03 22:11:41 +0200
commitf5a0cf0414fc3db7affcbe7ffcf4e251a2afd192 (patch)
tree12c225c9456f18d96cf8a587ce9a308f433da9e7 /src/table/merkle.rs
parentf05bb111c2e7dd77f2b34b82892bbfa8e6a063c1 (diff)
downloadgarage-f5a0cf0414fc3db7affcbe7ffcf4e251a2afd192.tar.gz
garage-f5a0cf0414fc3db7affcbe7ffcf4e251a2afd192.zip
fix clippy warnings on table
Diffstat (limited to 'src/table/merkle.rs')
-rw-r--r--src/table/merkle.rs19
1 files changed, 6 insertions, 13 deletions
diff --git a/src/table/merkle.rs b/src/table/merkle.rs
index 39b87aa1..5c5cbec7 100644
--- a/src/table/merkle.rs
+++ b/src/table/merkle.rs
@@ -111,8 +111,8 @@ where
}
} else {
select! {
- _ = self.data.merkle_todo_notify.notified().fuse() => (),
- _ = must_exit.changed().fuse() => (),
+ _ = self.data.merkle_todo_notify.notified().fuse() => {},
+ _ = must_exit.changed().fuse() => {},
}
}
}
@@ -121,10 +121,10 @@ where
fn update_item(&self, k: &[u8], vhash_by: &[u8]) -> Result<(), Error> {
let khash = blake2sum(k);
- let new_vhash = if vhash_by.len() == 0 {
+ let new_vhash = if vhash_by.is_empty() {
None
} else {
- Some(Hash::try_from(&vhash_by[..]).unwrap())
+ Some(Hash::try_from(vhash_by).unwrap())
};
let key = MerkleNodeKey {
@@ -168,14 +168,7 @@ where
// This update is an Option<_>, so that it is None if the update is a no-op
// and we can thus skip recalculating and re-storing everything
let mutate = match self.read_node_txn(tx, &key)? {
- MerkleNode::Empty => {
- if let Some(vhv) = new_vhash {
- Some(MerkleNode::Leaf(k.to_vec(), vhv))
- } else {
- // Nothing to do, keep empty node
- None
- }
- }
+ MerkleNode::Empty => new_vhash.map(|vhv| MerkleNode::Leaf(k.to_vec(), vhv)),
MerkleNode::Intermediate(mut children) => {
let key2 = key.next_key(khash);
if let Some(subhash) = self.update_item_rec(tx, k, khash, &key2, new_vhash)? {
@@ -186,7 +179,7 @@ where
intermediate_set_child(&mut children, key2.prefix[i], subhash);
}
- if children.len() == 0 {
+ if children.is_empty() {
// should not happen
warn!(
"({}) Replacing intermediate node with empty node, should not happen.",