diff options
| author | Trinity Pointard <trinity.pointard@gmail.com> | 2021-04-07 13:39:34 +0200 |
|---|---|---|
| committer | Alex Auvolat <alex@adnab.me> | 2021-04-27 16:49:07 +0200 |
| commit | 2812a027ea5a8ac0de22aedce9552c2420c07019 (patch) | |
| tree | 6ab505b1f5e5d43907c77fcb324df3f9718239ac /src/model | |
| parent | 74373aebcfdfcf5c03e4fb6510d8dd664a0b9b88 (diff) | |
| download | garage-2812a027ea5a8ac0de22aedce9552c2420c07019.tar.gz garage-2812a027ea5a8ac0de22aedce9552c2420c07019.zip | |
change some more comments and revert changes on TableSchema
Diffstat (limited to 'src/model')
| -rw-r--r-- | src/model/block.rs | 1 | ||||
| -rw-r--r-- | src/model/bucket_table.rs | 8 | ||||
| -rw-r--r-- | src/model/key_table.rs | 4 |
3 files changed, 2 insertions, 11 deletions
diff --git a/src/model/block.rs b/src/model/block.rs index 89685630..5f428fe1 100644 --- a/src/model/block.rs +++ b/src/model/block.rs @@ -250,7 +250,6 @@ impl BlockManager { } /// Decrement the number of time a block is used - // when counter reach 0, it seems not put to resync which I assume put it to gc? pub fn block_decref(&self, hash: &Hash) -> Result<(), Error> { let new_rc = self.rc.update_and_fetch(&hash, |old| { let old_v = old.map(u64_from_be_bytes).unwrap_or(0); diff --git a/src/model/bucket_table.rs b/src/model/bucket_table.rs index 8198deb7..6a4b021d 100644 --- a/src/model/bucket_table.rs +++ b/src/model/bucket_table.rs @@ -57,7 +57,7 @@ impl CRDT for BucketParams { } impl BucketParams { - /// Create a new default `BucketParams` + /// Initializes a new instance of the Bucket struct pub fn new() -> Self { BucketParams { authorized_keys: crdt::LWWMap::new(), @@ -75,7 +75,7 @@ impl Bucket { } } - /// Query if bucket is deleted + /// Returns true if this represents a deleted bucket pub fn is_deleted(&self) -> bool { *self.state.get() == BucketState::Deleted } @@ -113,10 +113,6 @@ impl TableSchema for BucketTable { type E = Bucket; type Filter = DeletedFilter; - fn updated(&self, _old: Option<Self::E>, _new: Option<Self::E>) { - // nothing to do when updated - } - fn matches_filter(entry: &Self::E, filter: &Self::Filter) -> bool { filter.apply(entry.is_deleted()) } diff --git a/src/model/key_table.rs b/src/model/key_table.rs index e1dcd7f4..578f8683 100644 --- a/src/model/key_table.rs +++ b/src/model/key_table.rs @@ -125,10 +125,6 @@ impl TableSchema for KeyTable { type E = Key; type Filter = KeyFilter; - fn updated(&self, _old: Option<Self::E>, _new: Option<Self::E>) { - // nothing to do when updated - } - fn matches_filter(entry: &Self::E, filter: &Self::Filter) -> bool { match filter { KeyFilter::Deleted(df) => df.apply(entry.deleted.get()), |