aboutsummaryrefslogtreecommitdiff
path: root/src/garage/tests/common/ext
diff options
context:
space:
mode:
authorAlex Auvolat <alex@adnab.me>2023-11-15 12:56:52 +0100
committerAlex Auvolat <alex@adnab.me>2023-11-15 12:56:52 +0100
commit46007bf01dd2e5b489d145ca0a5499ffa7257b96 (patch)
treeac85320b4e3ca00cfc695697e0696c8db4cf7822 /src/garage/tests/common/ext
parentb3e729f4b8ec3b06593f8d3b161c76b1263d9f13 (diff)
downloadgarage-46007bf01dd2e5b489d145ca0a5499ffa7257b96.tar.gz
garage-46007bf01dd2e5b489d145ca0a5499ffa7257b96.zip
integration test: print stdout and stderr on subcommand crash
Diffstat (limited to 'src/garage/tests/common/ext')
-rw-r--r--src/garage/tests/common/ext/process.rs44
1 files changed, 11 insertions, 33 deletions
diff --git a/src/garage/tests/common/ext/process.rs b/src/garage/tests/common/ext/process.rs
index ba533b6c..8e20bf7c 100644
--- a/src/garage/tests/common/ext/process.rs
+++ b/src/garage/tests/common/ext/process.rs
@@ -14,42 +14,20 @@ impl CommandExt for process::Command {
}
fn expect_success_status(&mut self, msg: &str) -> process::ExitStatus {
- let status = self.status().expect(msg);
- status.expect_success(msg);
- status
+ self.expect_success_output(msg).status
}
fn expect_success_output(&mut self, msg: &str) -> process::Output {
let output = self.output().expect(msg);
- output.expect_success(msg);
- output
- }
-}
-
-pub trait OutputExt {
- fn expect_success(&self, msg: &str);
-}
-
-impl OutputExt for process::Output {
- fn expect_success(&self, msg: &str) {
- self.status.expect_success(msg)
- }
-}
-
-pub trait ExitStatusExt {
- fn expect_success(&self, msg: &str);
-}
-
-impl ExitStatusExt for process::ExitStatus {
- fn expect_success(&self, msg: &str) {
- if !self.success() {
- match self.code() {
- Some(code) => panic!(
- "Command exited with code {code}: {msg}",
- code = code,
- msg = msg
- ),
- None => panic!("Command exited with signal: {msg}", msg = msg),
- }
+ if !output.status.success() {
+ panic!(
+ "{}: command {:?} exited with error {:?}\nSTDOUT: {}\nSTDERR: {}",
+ msg,
+ self,
+ output.status.code(),
+ String::from_utf8_lossy(&output.stdout),
+ String::from_utf8_lossy(&output.stderr)
+ );
}
+ output
}
}