Merge branch 'dev-0.2'

1 files changed, 119 insertions, 88 deletions

diff --git a/src/api/s3_put.rs b/src/api/s3_put.rs
index ec599a05..c4e3b818 100644
--- a/src/api/s3_put.rs
+++ b/src/api/s3_put.rs
@@ -5,11 +5,12 @@ use std::sync::Arc;
 use futures::stream::*;
 use hyper::{Body, Request, Response};
 use md5::{digest::generic_array::*, Digest as Md5Digest, Md5};
-use sha2::{Digest as Sha256Digest, Sha256};
+use sha2::Sha256;
 
 use garage_table::*;
 use garage_util::data::*;
 use garage_util::error::Error as GarageError;
+use garage_util::time::*;
 
 use garage_model::block::INLINE_THRESHOLD;
 use garage_model::block_ref_table::*;
@@ -52,14 +53,14 @@ pub async fn handle_put(
 	if first_block.len() < INLINE_THRESHOLD {
 		let mut md5sum = Md5::new();
 		md5sum.update(&first_block[..]);
-		let md5sum_arr = md5sum.finalize();
-		let md5sum_hex = hex::encode(md5sum_arr);
+		let data_md5sum = md5sum.finalize();
+		let data_md5sum_hex = hex::encode(data_md5sum);
 
-		let sha256sum_hash = sha256sum(&first_block[..]);
+		let data_sha256sum = sha256sum(&first_block[..]);
 
 		ensure_checksum_matches(
-			md5sum_arr.as_slice(),
-			sha256sum_hash,
+			data_md5sum.as_slice(),
+			data_sha256sum,
 			content_md5.as_deref(),
 			content_sha256,
 		)?;
@@ -71,7 +72,7 @@ pub async fn handle_put(
 				ObjectVersionMeta {
 					headers,
 					size: first_block.len() as u64,
-					etag: md5sum_hex.clone(),
+					etag: data_md5sum_hex.clone(),
 				},
 				first_block,
 			)),
@@ -80,41 +81,45 @@ pub async fn handle_put(
 		let object = Object::new(bucket.into(), key.into(), vec![object_version]);
 		garage.object_table.insert(&object).await?;
 
-		return Ok(put_response(version_uuid, md5sum_hex));
+		return Ok(put_response(version_uuid, data_md5sum_hex));
 	}
 
 	// Write version identifier in object table so that we have a trace
 	// that we are uploading something
 	let mut object_version = ObjectVersion {
 		uuid: version_uuid,
-		timestamp: now_msec(),
+		timestamp: version_timestamp,
 		state: ObjectVersionState::Uploading(headers.clone()),
 	};
 	let object = Object::new(bucket.into(), key.into(), vec![object_version.clone()]);
 	garage.object_table.insert(&object).await?;
 
 	// Initialize corresponding entry in version table
-	let version = Version::new(version_uuid, bucket.into(), key.into(), false, vec![]);
-	let first_block_hash = sha256sum(&first_block[..]);
+	// Write this entry now, even with empty block list,
+	// to prevent block_ref entries from being deleted (they can be deleted
+	// if the reference a version that isn't found in the version table)
+	let version = Version::new(version_uuid, bucket.into(), key.into(), false);
+	garage.version_table.insert(&version).await?;
 
 	// Transfer data and verify checksum
+	let first_block_hash = blake2sum(&first_block[..]);
 	let tx_result = read_and_put_blocks(
 		&garage,
-		version,
+		&version,
 		1,
 		first_block,
 		first_block_hash,
 		&mut chunker,
 	)
 	.await
-	.and_then(|(total_size, md5sum_arr, sha256sum)| {
+	.and_then(|(total_size, data_md5sum, data_sha256sum)| {
 		ensure_checksum_matches(
-			md5sum_arr.as_slice(),
-			sha256sum,
+			data_md5sum.as_slice(),
+			data_sha256sum,
 			content_md5.as_deref(),
 			content_sha256,
 		)
-		.map(|()| (total_size, md5sum_arr))
+		.map(|()| (total_size, data_md5sum))
 	});
 
 	// If something went wrong, clean up
@@ -148,13 +153,13 @@ pub async fn handle_put(
 /// Validate MD5 sum against content-md5 header
 /// and sha256sum against signed content-sha256
 fn ensure_checksum_matches(
-	md5sum: &[u8],
-	sha256sum: garage_util::data::FixedBytes32,
+	data_md5sum: &[u8],
+	data_sha256sum: garage_util::data::FixedBytes32,
 	content_md5: Option<&str>,
 	content_sha256: Option<garage_util::data::FixedBytes32>,
 ) -> Result<(), Error> {
 	if let Some(expected_sha256) = content_sha256 {
-		if expected_sha256 != sha256sum {
+		if expected_sha256 != data_sha256sum {
 			return Err(Error::BadRequest(format!(
 				"Unable to validate x-amz-content-sha256"
 			)));
@@ -163,7 +168,7 @@ fn ensure_checksum_matches(
 		}
 	}
 	if let Some(expected_md5) = content_md5 {
-		if expected_md5.trim_matches('"') != base64::encode(md5sum) {
+		if expected_md5.trim_matches('"') != base64::encode(data_md5sum) {
 			return Err(Error::BadRequest(format!("Unable to validate content-md5")));
 		} else {
 			trace!("Successfully validated content-md5");
@@ -173,8 +178,8 @@ fn ensure_checksum_matches(
 }
 
 async fn read_and_put_blocks(
-	garage: &Arc<Garage>,
-	version: Version,
+	garage: &Garage,
+	version: &Version,
 	part_number: u64,
 	first_block: Vec<u8>,
 	first_block_hash: Hash,
@@ -183,11 +188,11 @@ async fn read_and_put_blocks(
 	let mut md5hasher = Md5::new();
 	let mut sha256hasher = Sha256::new();
 	md5hasher.update(&first_block[..]);
-	sha256hasher.input(&first_block[..]);
+	sha256hasher.update(&first_block[..]);
 
 	let mut next_offset = first_block.len();
 	let mut put_curr_version_block = put_block_meta(
-		garage.clone(),
+		&garage,
 		&version,
 		part_number,
 		0,
@@ -203,11 +208,11 @@ async fn read_and_put_blocks(
 			futures::try_join!(put_curr_block, put_curr_version_block, chunker.next())?;
 		if let Some(block) = next_block {
 			md5hasher.update(&block[..]);
-			sha256hasher.input(&block[..]);
-			let block_hash = sha256sum(&block[..]);
+			sha256hasher.update(&block[..]);
+			let block_hash = blake2sum(&block[..]);
 			let block_len = block.len();
 			put_curr_version_block = put_block_meta(
-				garage.clone(),
+				&garage,
 				&version,
 				part_number,
 				next_offset as u64,
@@ -222,39 +227,35 @@ async fn read_and_put_blocks(
 	}
 
 	let total_size = next_offset as u64;
-	let md5sum_arr = md5hasher.finalize();
+	let data_md5sum = md5hasher.finalize();
 
-	let sha256sum_arr = sha256hasher.result();
-	let mut hash = [0u8; 32];
-	hash.copy_from_slice(&sha256sum_arr[..]);
-	let sha256sum_arr = Hash::from(hash);
+	let data_sha256sum = sha256hasher.finalize();
+	let data_sha256sum = Hash::try_from(&data_sha256sum[..]).unwrap();
 
-	Ok((total_size, md5sum_arr, sha256sum_arr))
+	Ok((total_size, data_md5sum, data_sha256sum))
 }
 
 async fn put_block_meta(
-	garage: Arc<Garage>,
+	garage: &Garage,
 	version: &Version,
 	part_number: u64,
 	offset: u64,
 	hash: Hash,
 	size: u64,
 ) -> Result<(), GarageError> {
-	// TODO: don't clone, restart from empty block list ??
 	let mut version = version.clone();
-	version
-		.add_block(VersionBlock {
+	version.blocks.put(
+		VersionBlockKey {
 			part_number,
 			offset,
-			hash,
-			size,
-		})
-		.unwrap();
+		},
+		VersionBlock { hash, size },
+	);
 
 	let block_ref = BlockRef {
 		block: hash,
 		version: version.uuid,
-		deleted: false,
+		deleted: false.into(),
 	};
 
 	futures::try_join!(
@@ -319,6 +320,7 @@ pub async fn handle_create_multipart_upload(
 	let version_uuid = gen_uuid();
 	let headers = get_headers(req)?;
 
+	// Create object in object table
 	let object_version = ObjectVersion {
 		uuid: version_uuid,
 		timestamp: now_msec(),
@@ -327,6 +329,14 @@ pub async fn handle_create_multipart_upload(
 	let object = Object::new(bucket.to_string(), key.to_string(), vec![object_version]);
 	garage.object_table.insert(&object).await?;
 
+	// Insert empty version so that block_ref entries refer to something
+	// (they are inserted concurrently with blocks in the version table, so
+	// there is the possibility that they are inserted before the version table
+	// is created, in which case it is allowed to delete them, e.g. in repair_*)
+	let version = Version::new(version_uuid, bucket.into(), key.into(), false);
+	garage.version_table.insert(&version).await?;
+
+	// Send success response
 	let mut xml = String::new();
 	writeln!(&mut xml, r#"<?xml version="1.0" encoding="UTF-8"?>"#).unwrap();
 	writeln!(
@@ -389,11 +399,11 @@ pub async fn handle_put_part(
 	}
 
 	// Copy block to store
-	let version = Version::new(version_uuid, bucket, key, false, vec![]);
-	let first_block_hash = sha256sum(&first_block[..]);
-	let (_, md5sum_arr, sha256sum) = read_and_put_blocks(
+	let version = Version::new(version_uuid, bucket, key, false);
+	let first_block_hash = blake2sum(&first_block[..]);
+	let (_, data_md5sum, data_sha256sum) = read_and_put_blocks(
 		&garage,
-		version,
+		&version,
 		part_number,
 		first_block,
 		first_block_hash,
@@ -401,15 +411,24 @@ pub async fn handle_put_part(
 	)
 	.await?;
 
+	// Verify that checksums map
 	ensure_checksum_matches(
-		md5sum_arr.as_slice(),
-		sha256sum,
+		data_md5sum.as_slice(),
+		data_sha256sum,
 		content_md5.as_deref(),
 		content_sha256,
 	)?;
 
+	// Store part etag in version
+	let data_md5sum_hex = hex::encode(data_md5sum);
+	let mut version = version;
+	version
+		.parts_etags
+		.put(part_number, data_md5sum_hex.clone());
+	garage.version_table.insert(&version).await?;
+
 	let response = Response::builder()
-		.header("ETag", format!("\"{}\"", hex::encode(md5sum_arr)))
+		.header("ETag", format!("\"{}\"", data_md5sum_hex))
 		.body(Body::from(vec![]))
 		.unwrap();
 	Ok(response)
@@ -444,17 +463,15 @@ pub async fn handle_complete_multipart_upload(
 	)?;
 
 	let object = object.ok_or(Error::BadRequest(format!("Object not found")))?;
-	let object_version = object
+	let mut object_version = object
 		.versions()
 		.iter()
-		.find(|v| v.uuid == version_uuid && v.is_uploading());
-	let mut object_version = match object_version {
-		None => return Err(Error::NotFound),
-		Some(x) => x.clone(),
-	};
+		.find(|v| v.uuid == version_uuid && v.is_uploading())
+		.cloned()
+		.ok_or(Error::BadRequest(format!("Version not found")))?;
 
 	let version = version.ok_or(Error::BadRequest(format!("Version not found")))?;
-	if version.blocks().len() == 0 {
+	if version.blocks.len() == 0 {
 		return Err(Error::BadRequest(format!("No data was uploaded")));
 	}
 
@@ -464,53 +481,50 @@ pub async fn handle_complete_multipart_upload(
 	};
 
 	// Check that the list of parts they gave us corresponds to the parts we have here
-	// TODO: check MD5 sum of all uploaded parts? but that would mean we have to store them somewhere...
-	let mut parts = version
-		.blocks()
+	debug!("Expected parts from request: {:?}", body_list_of_parts);
+	debug!("Parts stored in version: {:?}", version.parts_etags.items());
+	let parts = version
+		.parts_etags
+		.items()
 		.iter()
-		.map(|x| x.part_number)
-		.collect::<Vec<_>>();
-	parts.dedup();
+		.map(|pair| (&pair.0, &pair.1));
 	let same_parts = body_list_of_parts
 		.iter()
-		.map(|x| &x.part_number)
-		.eq(parts.iter());
+		.map(|x| (&x.part_number, &x.etag))
+		.eq(parts);
 	if !same_parts {
 		return Err(Error::BadRequest(format!("We don't have the same parts")));
 	}
 
-	// ETag calculation: we produce ETags that have the same form as
-	// those of S3 multipart uploads, but we don't use their actual
-	// calculation for the first part (we use random bytes). This
-	// shouldn't impact compatibility as the S3 docs specify that
-	// the ETag is an opaque value in case of a multipart upload.
-	// See also: https://teppen.io/2018/06/23/aws_s3_etags/
-	let num_parts = version.blocks().last().unwrap().part_number
-		- version.blocks().first().unwrap().part_number
+	// Calculate etag of final object
+	// To understand how etags are calculated, read more here:
+	// https://teppen.io/2018/06/23/aws_s3_etags/
+	let num_parts = version.blocks.items().last().unwrap().0.part_number
+		- version.blocks.items().first().unwrap().0.part_number
 		+ 1;
-	let etag = format!(
-		"{}-{}",
-		hex::encode(&rand::random::<[u8; 16]>()[..]),
-		num_parts
-	);
+	let mut etag_md5_hasher = Md5::new();
+	for (_, etag) in version.parts_etags.items().iter() {
+		etag_md5_hasher.update(etag.as_bytes());
+	}
+	let etag = format!("{}-{}", hex::encode(etag_md5_hasher.finalize()), num_parts);
 
-	let total_size = version
-		.blocks()
-		.iter()
-		.map(|x| x.size)
-		.fold(0, |x, y| x + y);
+	// Calculate total size of final object
+	let total_size = version.blocks.items().iter().map(|x| x.1.size).sum();
+
+	// Write final object version
 	object_version.state = ObjectVersionState::Complete(ObjectVersionData::FirstBlock(
 		ObjectVersionMeta {
 			headers,
 			size: total_size,
-			etag: etag,
+			etag,
 		},
-		version.blocks()[0].hash,
+		version.blocks.items()[0].1.hash,
 	));
 
 	let final_object = Object::new(bucket.clone(), key.clone(), vec![object_version]);
 	garage.object_table.insert(&final_object).await?;
 
+	// Send response saying ok we're done
 	let mut xml = String::new();
 	writeln!(&mut xml, r#"<?xml version="1.0" encoding="UTF-8"?>"#).unwrap();
 	writeln!(
@@ -570,17 +584,19 @@ fn get_mime_type(req: &Request<Body>) -> Result<String, Error> {
 		.to_string())
 }
 
-fn get_headers(req: &Request<Body>) -> Result<ObjectVersionHeaders, Error> {
+pub(crate) fn get_headers(req: &Request<Body>) -> Result<ObjectVersionHeaders, Error> {
 	let content_type = get_mime_type(req)?;
-	let other_headers = vec![
+	let mut other = BTreeMap::new();
+
+	// Preserve standard headers
+	let standard_header = vec![
 		hyper::header::CACHE_CONTROL,
 		hyper::header::CONTENT_DISPOSITION,
 		hyper::header::CONTENT_ENCODING,
 		hyper::header::CONTENT_LANGUAGE,
 		hyper::header::EXPIRES,
 	];
-	let mut other = BTreeMap::new();
-	for h in other_headers.iter() {
+	for h in standard_header.iter() {
 		if let Some(v) = req.headers().get(h) {
 			match v.to_str() {
 				Ok(v_str) => {
@@ -592,6 +608,21 @@ fn get_headers(req: &Request<Body>) -> Result<ObjectVersionHeaders, Error> {
 			}
 		}
 	}
+
+	// Preserve x-amz-meta- headers
+	for (k, v) in req.headers().iter() {
+		if k.as_str().starts_with("x-amz-meta-") {
+			match v.to_str() {
+				Ok(v_str) => {
+					other.insert(k.to_string(), v_str.to_string());
+				}
+				Err(e) => {
+					warn!("Discarding header {}, error in .to_str(): {}", k, e);
+				}
+			}
+		}
+	}
+
 	Ok(ObjectVersionHeaders {
 		content_type,
 		other,