check_quotas: avoid re-fetching object from object table

1 files changed, 10 insertions, 8 deletions

diff --git a/src/api/s3/put.rs b/src/api/s3/put.rs
index bd032165..a3fe9cca 100644
--- a/src/api/s3/put.rs
+++ b/src/api/s3/put.rs
@@ -87,6 +87,7 @@ pub(crate) async fn save_stream<S: Stream<Item = Result<Bytes, Error>> + Unpin>(
 	// Generate identity of new version
 	let version_uuid = gen_uuid();
 	let version_timestamp = existing_object
+		.as_ref()
 		.and_then(|obj| obj.versions().iter().map(|v| v.timestamp).max())
 		.map(|t| std::cmp::max(t + 1, now_msec()))
 		.unwrap_or_else(now_msec);
@@ -109,7 +110,7 @@ pub(crate) async fn save_stream<S: Stream<Item = Result<Bytes, Error>> + Unpin>(
 			content_sha256,
 		)?;
 
-		check_quotas(&garage, bucket, key, size).await?;
+		check_quotas(&garage, bucket, key, size, existing_object.as_ref()).await?;
 
 		let object_version = ObjectVersion {
 			uuid: version_uuid,
@@ -188,7 +189,7 @@ pub(crate) async fn save_stream<S: Stream<Item = Result<Bytes, Error>> + Unpin>(
 		content_sha256,
 	)?;
 
-	check_quotas(&garage, bucket, key, total_size).await?;
+	check_quotas(&garage, bucket, key, total_size, existing_object.as_ref()).await?;
 
 	// Save final object state, marked as Complete
 	let md5sum_hex = hex::encode(data_md5sum);
@@ -243,17 +244,18 @@ pub(crate) async fn check_quotas(
 	bucket: &Bucket,
 	key: &str,
 	size: u64,
+	prev_object: Option<&Object>,
 ) -> Result<(), Error> {
 	let quotas = bucket.state.as_option().unwrap().quotas.get();
 	if quotas.max_objects.is_none() && quotas.max_size.is_none() {
 		return Ok(());
 	};
 
-	let key = key.to_string();
-	let (prev_object, counters) = futures::try_join!(
-		garage.object_table.get(&bucket.id, &key),
-		garage.object_counter_table.table.get(&bucket.id, &EmptyKey),
-	)?;
+	let counters = garage
+		.object_counter_table
+		.table
+		.get(&bucket.id, &EmptyKey)
+		.await?;
 
 	let counters = counters
 		.map(|x| x.filtered_values(&garage.system.ring.borrow()))
@@ -287,7 +289,7 @@ pub(crate) async fn check_quotas(
 		if cnt_size_diff > 0 && current_size + cnt_size_diff > ms as i64 {
 			return Err(Error::forbidden(format!(
 				"Bucket size quota is reached, maximum total size of objects for this bucket: {}. The bucket is already {} bytes, and this object would add {} bytes.",
-				ms, current_size, size
+				ms, current_size, cnt_size_diff
 			)));
 		}
 	}