Vendor goldap, fix ASN.1 BER integer and length encoding

 - Add tests for goldap to prevent regressions
 - Disable reconnection for our functional tests

1 files changed, 37 insertions, 0 deletions

diff --git a/goldap/authentication_choice.go b/goldap/authentication_choice.go
new file mode 100644
index 0000000..804d84d
--- /dev/null
+++ b/goldap/authentication_choice.go
@@ -0,0 +1,37 @@
+package message
+
+import "fmt"
+
+//
+//        AuthenticationChoice ::= CHOICE {
+//             simple                  [0] OCTET STRING,
+//                                     -- 1 and 2 reserved
+//             sasl                    [3] SaslCredentials,
+//             ...  }
+
+func readAuthenticationChoice(bytes *Bytes) (ret AuthenticationChoice, err error) {
+	tagAndLength, err := bytes.PreviewTagAndLength()
+	if err != nil {
+		err = LdapError{fmt.Sprintf("readAuthenticationChoice:\n%s", err.Error())}
+		return
+	}
+	err = tagAndLength.ExpectClass(classContextSpecific)
+	if err != nil {
+		err = LdapError{fmt.Sprintf("readAuthenticationChoice:\n%s", err.Error())}
+		return
+	}
+	switch tagAndLength.Tag {
+	case TagAuthenticationChoiceSimple:
+		ret, err = readTaggedOCTETSTRING(bytes, classContextSpecific, TagAuthenticationChoiceSimple)
+	case TagAuthenticationChoiceSaslCredentials:
+		ret, err = readSaslCredentials(bytes)
+	default:
+		err = LdapError{fmt.Sprintf("readAuthenticationChoice: invalid tag value %d for AuthenticationChoice", tagAndLength.Tag)}
+		return
+	}
+	if err != nil {
+		err = LdapError{fmt.Sprintf("readAuthenticationChoice:\n%s", err.Error())}
+		return
+	}
+	return
+}