From a393429f01e63aa37f58f8cbe4a810e59852fa61 Mon Sep 17 00:00:00 2001
From: Drew DeVault <sir@cmpwn.com>
Date: Thu, 29 Oct 2020 15:18:36 -0400
Subject: Implement JavaScript UI for attachments

This one is a bit of a doozy. A summary of the changes:

- Session has grown storage for attachments which have been uploaded but
  not yet sent.
- The list of attachments on a message is refcounted so that we can
  clean up the temporary files only after it's done with - i.e. after
  copying to Sent and after all of the SMTP attempts are done.
- Abandoned attachments are cleared out on process shutdown.

Future work:
- Add a limit to the maximum number of pending attachments the user can
  have in the session.
- Periodically clean out abandoned attachments?
---
 plugins/base/routes.go | 50 ++++++++++++++++++++++++++++++++++++++++++++++++--
 plugins/base/smtp.go   | 47 +++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 95 insertions(+), 2 deletions(-)

(limited to 'plugins/base')

diff --git a/plugins/base/routes.go b/plugins/base/routes.go
index 0277174..c9df564 100644
--- a/plugins/base/routes.go
+++ b/plugins/base/routes.go
@@ -46,6 +46,8 @@ func registerRoutes(p *alps.GoPlugin) {
 	p.GET("/compose", handleComposeNew)
 	p.POST("/compose", handleComposeNew)
 
+	p.POST("/compose/attachment", handleComposeAttachment)
+
 	p.GET("/message/:mbox/:uid/reply", handleReply)
 	p.POST("/message/:mbox/:uid/reply", handleReply)
 
@@ -414,11 +416,19 @@ type composeOptions struct {
 // Send message, append it to the Sent mailbox, mark the original message as
 // answered
 func submitCompose(ctx *alps.Context, msg *OutgoingMessage, options *composeOptions) error {
+	msg.Ref()
+	msg.Ref()
 	task := work.NewTask(func(_ context.Context) error {
-		return ctx.Session.DoSMTP(func (c *smtp.Client) error {
+		err := ctx.Session.DoSMTP(func (c *smtp.Client) error {
 			return sendMessage(c, msg)
 		})
-	}).Retries(5)
+		if err != nil {
+			ctx.Logger().Printf("Error sending email: %v\n", err)
+		}
+		return err
+	}).Retries(5).After(func(_ context.Context, task *work.Task) {
+		msg.Unref()
+	})
 	err := ctx.Server.Queue.Enqueue(task)
 	if err != nil {
 		if _, ok := err.(alps.AuthError); ok {
@@ -440,6 +450,7 @@ func submitCompose(ctx *alps.Context, msg *OutgoingMessage, options *composeOpti
 		if _, err := appendMessage(c, msg, mailboxSent); err != nil {
 			return err
 		}
+		msg.Unref()
 		if draft := options.Draft; draft != nil {
 			if err := deleteMessage(c, draft.Mailbox, draft.Uid); err != nil {
 				return err
@@ -533,6 +544,19 @@ func handleCompose(ctx *alps.Context, msg *OutgoingMessage, options *composeOpti
 			msg.Attachments = append(msg.Attachments, &formAttachment{fh})
 		}
 
+		uuids := ctx.FormValue("attachment-uuids")
+		for _, uuid := range strings.Split(uuids, ",") {
+			attachment := ctx.Session.PopAttachment(uuid)
+			if attachment == nil {
+				return fmt.Errorf("Unable to retrieve message attachments from session")
+			}
+			msg.Attachments = append(msg.Attachments, &refcountedAttachment{
+				attachment.File,
+				attachment.Form,
+				0,
+			})
+		}
+
 		if saveAsDraft {
 			err = ctx.Session.DoIMAP(func(c *imapclient.Client) error {
 				copied, err := appendMessage(c, msg, mailboxDrafts)
@@ -575,6 +599,28 @@ func handleComposeNew(ctx *alps.Context) error {
 	}, &composeOptions{})
 }
 
+func handleComposeAttachment(ctx *alps.Context) error {
+	reader, err := ctx.Request().MultipartReader()
+	if err != nil {
+		return fmt.Errorf("failed to get multipart form: %v", err)
+	}
+	form, err := reader.ReadForm(32 << 20) // 32 MB
+	if err != nil {
+		return fmt.Errorf("failed to decode multipart form: %v", err)
+	}
+
+	var uuids []string
+	for _, fh := range form.File["attachments"] {
+		uuid, err := ctx.Session.PutAttachment(fh, form)
+		if err != nil {
+			return err
+		}
+		uuids = append(uuids, uuid)
+	}
+
+	return ctx.JSON(http.StatusOK, &uuids)
+}
+
 func unwrapIMAPAddressList(addrs []*imap.Address) []string {
 	l := make([]string, len(addrs))
 	for i, addr := range addrs {
diff --git a/plugins/base/smtp.go b/plugins/base/smtp.go
index dc8211e..a6cfd3d 100644
--- a/plugins/base/smtp.go
+++ b/plugins/base/smtp.go
@@ -53,6 +53,37 @@ func (att *formAttachment) Filename() string {
 	return att.FileHeader.Filename
 }
 
+type refcountedAttachment struct {
+	*multipart.FileHeader
+	*multipart.Form
+	refs int
+}
+
+func (att *refcountedAttachment) Open() (io.ReadCloser, error) {
+	return att.FileHeader.Open()
+}
+
+func (att *refcountedAttachment) MIMEType() string {
+	// TODO: retain params, e.g. "charset"?
+	t, _, _ := mime.ParseMediaType(att.FileHeader.Header.Get("Content-Type"))
+	return t
+}
+
+func (att *refcountedAttachment) Filename() string {
+	return att.FileHeader.Filename
+}
+
+func (att *refcountedAttachment) Ref() {
+	att.refs += 1
+}
+
+func (att *refcountedAttachment) Unref() {
+	att.refs -= 1
+	if att.refs == 0 {
+		att.Form.RemoveAll()
+	}
+}
+
 type imapAttachment struct {
 	Mailbox string
 	Uid     uint32
@@ -176,6 +207,22 @@ func (msg *OutgoingMessage) WriteTo(w io.Writer) error {
 	return nil
 }
 
+func (msg *OutgoingMessage) Ref() {
+	for _, a := range msg.Attachments {
+		if a, ok := a.(*refcountedAttachment); ok {
+			a.Ref()
+		}
+	}
+}
+
+func (msg *OutgoingMessage) Unref() {
+	for _, a := range msg.Attachments {
+		if a, ok := a.(*refcountedAttachment); ok {
+			a.Unref()
+		}
+	}
+}
+
 func sendMessage(c *smtp.Client, msg *OutgoingMessage) error {
 	if err := c.Mail(msg.From, nil); err != nil {
 		return fmt.Errorf("MAIL FROM failed: %v", err)
-- 
cgit v1.2.3